Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--grep option now supports real regular expressions but not masks only. #204

Merged
merged 1 commit into from
May 4, 2018

Conversation

toolmagic
Copy link
Contributor

@toolmagic toolmagic commented Mar 29, 2018

To use real regular expressions, use the traditional JavaScript syntax:

karma run -- --grep=/<regex>/<flags>

Sample:

karma run -- --grep=/.*should.*/i

This implementation only extends the functionality without breaking the existing syntax.
You can continue to use the old syntax:

karma run -- --grep=RootTestSuite

To use real regular expressions, use the traditional JavaScript syntax:
> karma run -- --grep=/<regex>/<flags>
Sample:
> karma run -- --grep=/.*should.*/i

This implementation only extends the functionality without breaking the existing syntax.
You can continue to use the old syntax:
> karma run -- --grep=RootTestSuite
@maksimr
Copy link
Contributor

maksimr commented May 4, 2018

LGTM

@dignifiedquire @zzo can we merge this PR?
Thanks!

@johnjbarton johnjbarton merged commit 3b20480 into karma-runner:master May 4, 2018
@maksimr
Copy link
Contributor

maksimr commented May 4, 2018

@johnjbarton Thanks! We can close this PR #134 too because it duplicates

@zzo
Copy link
Contributor

zzo commented May 4, 2018

done thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants