Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Mac WebGL): Allow headless to use GPU #269

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elalish
Copy link

@elalish elalish commented Apr 21, 2023

Fixes #263

Replacing #266.

@pmvald
Copy link
Member

pmvald commented Apr 21, 2023

Again, commit message error. Almost all the PRs have this problem! It should be fix: allow headless to use GPU - this formatting is needed for release workflow to generated changelist and version automatically.

@elalish
Copy link
Author

elalish commented Apr 21, 2023

Maybe time to remove the commitlint test? Especially since I don't think Github's web editor allows one to change the commit message...

@pmvald
Copy link
Member

pmvald commented Apr 21, 2023

The commit formats have to follow that format in order for semantic release tool to create correct changelogs and version. The commit message can be changed by author. You can just go git reset --soft HEAD~1 && git commit -c ORIG_HEAD && git push --force-with-lease or use git rebase -i HEAD~1. Btw, I imagine this commit message format should be pretty common since most repos these days use this semantic release tool or similar tools and these tools usually follow the angular message formatting. We also mentioned this in our contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome headless lost WebGL support on MacOS
2 participants