Skip to content
This repository was archived by the owner on Jul 28, 2023. It is now read-only.

Conversation

@Varun-garg
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Varun-garg
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kalamcs kalamcs merged commit ab0fd5f into karma-runner:master Mar 26, 2019
@Varun-garg Varun-garg deleted the officialLocal branch March 26, 2019 14:09
@Pringels
Copy link
Contributor

Pringels commented Mar 28, 2019

@Varun-garg This merge broke all our tests :( Can you please provide some context as to why this pull request was necessary?

@Varun-garg
Copy link
Contributor Author

Hey @Pringels I just ran samples in this repo after upgrading the version and tests seemed to have run fine. We upgraded this repo because there were some cases where browserstacktunnel-wrapper was not able to properly download the BrowserStack Local binaries. Could you provide the logs so we can debug further?

@Pringels
Copy link
Contributor

@Varun-garg the log simply indicates that Browserstack was unable to connect to our CI agents. (connection refused) I didn't spend much time investigating as I had an urgent release, so I just rolled back to 1.4. I will investigate further next week and get back to you.

@csvn
Copy link
Contributor

csvn commented Aug 15, 2019

@Pringels I think your CI broke due to either #155 or #156. I'm planning a PR to fix both as soon as I can.

Ping @Varun-garg

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants