Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle basePath option for preprocessors paths #189

Conversation

ValentinH
Copy link
Contributor

fix: handle basePath option for preprocessors paths

Closes #146

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ValentinH
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks :octocat:

@dignifiedquire dignifiedquire merged commit e81dc13 into karma-runner:master May 26, 2016
@ValentinH
Copy link
Contributor Author

When will it be released?

@dignifiedquire
Copy link
Member

Now as 2.0.0

@ValentinH
Copy link
Contributor Author

ValentinH commented May 26, 2016

\o/ Just for my knowledge, why 2.0.0 and not 1.0.1?

@dignifiedquire
Copy link
Member

dignifiedquire commented May 26, 2016

Because while it is a bug fix, it's technically a breaking change to the behaviour in 1.0.0 so I went with a full major upgrade

@ValentinH
Copy link
Contributor Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.10.x breaks ng-html2js-preprocessor
3 participants