-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add benchmarks #89
Conversation
762d90e
to
c08d0bf
Compare
Regarding error I don't see How is this repo building at all? 🤔 EDIT: Updated to 1.19 |
Can the .idea folder be removed (possibly added to your I think |
470739f
to
3fdeeaf
Compare
b490ee8
to
d337460
Compare
d337460
to
01c0563
Compare
@karlseguin i wrote the basic cases but i feel like we need more to cover more configuration scenarios. For example the number of buckets. The default is 16 but what if I set 1000, what should the effect be? More speed but more memory? |
I think the next step would be to add some degree of concurrency, which is where the number of buckets would have an impact. More buckets will improve performance up to a point, at the cost of more memory. I'm not really sure how well Go's benchmark are for this type of more complex benchmark where you aren't just testing 1 narrow behavior though. (A few uncommon operations, e.g. |
@karlseguin why didn't you do a squash and merge? The git commit history looks horrible 😭 Can you fix it and force push? |
Addresses #24