reduction of debug output and parsing of all package formats #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows aggregating invalid data (of which typically only the first and/or last bytes matter). this patch only changes the format of reporting, and does not include said output optimizations (in fact, it drops the output of invalid data completely).
successive messags of invalid frames are aggregated, and output at the latest possible time (before something else is printed), possibly in truncated form.
of those, only timestamps are parsed into something usable. extensions and reserved packages could be parsed a little further, but only to a meaningless 32bit value.
|
This makes some things better, sure, but I'm still losing sync. Not sure if that's related to this change though. I probably want to somehow get a single line printed when sync is lost, rather than the all or nothing of the original code vs this code :) I've at least managed to get some PC sampling working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first two patches reduce the amount of data that gets printed when out of sync, the last one parses the missing formats and adds output for the time stamps