Additions to Mrf24j40 arduino library #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Added new 'Mrf24j::send16' function with third attribute - 'length' to be able to send binary data instead of string over 802.15.4 interface 2.Variable 'frame_length' moved onto a new position within 'Mrf24j:interrupt_handler' function before its usage. Old position is commented.
Added void send16(word dest16, char * data, byte length); definition.
karlp
reviewed
Feb 6, 2017
| @@ -148,6 +149,41 @@ void Mrf24j::send16(word dest16, char * data) { | |||
| write_short(MRF_TXNCON, (1<<MRF_TXNACKREQ | 1<<MRF_TXNTRIG)); | |||
| } | |||
|
|
|||
| void Mrf24j::send16(word dest16, char * data, byte length) { | |||
There was a problem hiding this comment.
THe right way of doing this is not to copy the whole function, but to make this new function be the "primary" function, and have the existing send16() function do the strlen() and then call this function. Duplication is never ok for this sort of thing.
karlp
reviewed
Feb 6, 2017
| @@ -219,11 +255,14 @@ void Mrf24j::interrupt_handler(void) { | |||
| // buffer data bytes | |||
| int rd_ptr = 0; | |||
| // from (0x301 + bytes_MHR) to (0x301 + frame_length - bytes_nodata - 1) | |||
|
|
|||
| rx_info.frame_length = frame_length; // new position here | |||
|
|
|||
There was a problem hiding this comment.
What's this change for? This seems like a separate unrelated issue.
karlp
reviewed
Feb 6, 2017
| @@ -220,6 +220,8 @@ class Mrf24j | |||
| void set_palna(boolean enabled); | |||
|
|
|||
| void send16(word dest16, char * data); | |||
|
|
|||
| void send16(word dest16, char * data, byte length); | |||
There was a problem hiding this comment.
You should make the header change in the same commit as the .cpp change. Each individual commit should contain what is needed for the change. By splitting the commits in two, you have a commit that doesn't compile properly.
You can use git rebase to squish them back into one commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I added two additions into your library. Please see the comments for the corresponding files. The additions were useful in my projects so far.