fix(collect): actually clear collectUrl when switching to non-Seek source#9
Merged
fix(collect): actually clear collectUrl when switching to non-Seek source#9
Conversation
* fix: add quick-start-only search profiles view * fix: point migration banner to quick-start view
* fix: add quick-start-only search profiles view * fix: point migration banner to quick-start view * fix: correct virtualized search result offset
Co-authored-by: karlcc <3255660+karlcc@users.noreply.github.com>
…urce The updater (current) => (current ?? undefined) === current ? current : undefined was tautological — the condition is always true for any string or undefined, so the stale collectUrl was never cleared on source switch. Replace with a direct setSessionCollectUrl(undefined) call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleCollectionSourceChangewas callingsetSessionCollectUrlwith an updater function whose condition(current ?? undefined) === currentis alwaystruefor any string orundefined— making it a no-op that never cleared the stale URLsetSessionCollectUrl(undefined)so switching to a non-Seek source (Job5156, 51job) reliably discards any previously storedcollectUrlTest plan
cd apps/web && npx tsc --noEmit— no type errorsnpm test -- --run src/hooks/useResumeListState.test.tsx— 50/50 passmake check— all checks passhttps://ehire.51job.com/...not a stale Job5156 URL