Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse timestamp cookies for SCHEDULED and DEADLINE #60

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Parse timestamp cookies for SCHEDULED and DEADLINE #60

merged 4 commits into from
Jan 4, 2023

Conversation

j3soon
Copy link
Contributor

@j3soon j3soon commented Nov 14, 2022

Fix #15 completely.

Related: #50

This PR also follows setuptools_scm v7.0.0 to drop Python 3.6 support, since orgparse requires setuptools_scm.

Update: Python 3.6 support is already dropped in a later commit (0041aad).

@j3soon
Copy link
Contributor Author

j3soon commented Dec 27, 2022

I've slightly modify tox.ini in this PR to pass the tests (see 6426a6a). Please let me know if I should open a separate PR for those modifications.

Copy link
Contributor Author

@j3soon j3soon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some notes regarding the changes.

@@ -1,10 +1,10 @@
[tox]
minversion = 3.5
minversion = 3.7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0041aad drops Python 3.6 support but forgot to update minversion for tox.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually tox version (and I don't even remember why minversion was required here). But doesn't hurt anyway :)

@j3soon
Copy link
Contributor Author

j3soon commented Dec 31, 2022

Just pinging this PR, as it's been 1.5 months since it was initially submitted.

Copy link
Owner

@karlicoss karlicoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey -- sorry, I've somehow missed the original notification!
Thanks again for a clean and well tested contribution!

@@ -1,10 +1,10 @@
[tox]
minversion = 3.5
minversion = 3.7
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually tox version (and I don't even remember why minversion was required here). But doesn't hurt anyway :)

@karlicoss karlicoss merged commit 28018a3 into karlicoss:master Jan 4, 2023
@karlicoss
Copy link
Owner

released to pypi as 0.3.2 !

@j3soon
Copy link
Contributor Author

j3soon commented Jan 12, 2023

Thanks! I just tested the new version on PyPI and verified the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date repeat
2 participants