-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse timestamp cookies for SCHEDULED and DEADLINE #60
Conversation
See the following link for further information: https://tox.wiki/en/latest/changelog.html#improved-documentation-4-0-3
I've slightly modify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some notes regarding the changes.
@@ -1,10 +1,10 @@ | |||
[tox] | |||
minversion = 3.5 | |||
minversion = 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0041aad drops Python 3.6 support but forgot to update minversion
for tox
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually tox version (and I don't even remember why minversion was required here). But doesn't hurt anyway :)
Just pinging this PR, as it's been 1.5 months since it was initially submitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey -- sorry, I've somehow missed the original notification!
Thanks again for a clean and well tested contribution!
@@ -1,10 +1,10 @@ | |||
[tox] | |||
minversion = 3.5 | |||
minversion = 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually tox version (and I don't even remember why minversion was required here). But doesn't hurt anyway :)
released to pypi as |
Thanks! I just tested the new version on PyPI and verified the fix. |
Fix #15 completely.
Related: #50
This PR also follows setuptools_scm v7.0.0 to drop Python 3.6 support, since orgparse requiressetuptools_scm
.Update: Python 3.6 support is already dropped in a later commit (0041aad).