Skip to content

location: make accuracy default config floats #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2023
Merged

location: make accuracy default config floats #314

merged 1 commit into from
Oct 1, 2023

Conversation

purarue
Copy link
Contributor

@purarue purarue commented Sep 30, 2023

@purarue
location: make accuracy default config floats
7511564 
previously they were ints which could possibly
break caching with cachew
@purarue purarue force-pushed the make-accuracy-floats branch from 84759c9 to 7511564 Compare September 30, 2023 21:25
@purarue purarue changed the title fix: make float accuracy defaults floats location: make accuracy default config floats Sep 30, 2023
@purarue
Copy link
Contributor Author

purarue commented Sep 30, 2023

weird, looks like pep517 related error: https://github.com/karlicoss/HPI/actions/runs/6365711590/job/17282936363#step:5:70

@karlicoss karlicoss merged commit f350761 into karlicoss:master Oct 1, 2023
@karlicoss
Copy link
Owner

Perhaps it's the parallel install once again? Anyway I retried and it worked.

@karlicoss
Copy link
Owner

Thanks! I wonder if there is a setting in mypy we could use to catch these? Fells like it's more often than not we want to avoid these coercions, although I might underestimate how often they are used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@purarue @karlicoss