my.core.logging: compatibility with HPI_LOGS #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks good! |
|
Yeah, I think I mentioned the same in #305, can update the docs to something more consistent |
purarue
force-pushed
the
logging-doc-updates
branch
from
21fd6bb to
31c7013
Compare
re-adds a removed check for HPI_LOGS, add some docs fix the checks for browserexport/takeout logs to use the computed level from my.core.logging
purarue
force-pushed
the
logging-doc-updates
branch
from
31c7013 to
374ecaf
Compare
|
Should be good, added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had tried to set the
DEFAULT_LEVELlike we discussed in #305 here:HPI/my/core/logging.py
Line 49 in c283e54
But if the module had already set a level like:
then any attempt to use
HPI_LOGS(which would use theDEFAULT_LEVEL) would be ignored, which is not what the user would expect (they'd expect the--debugflag to just override everything)So, added a check after the
LOGGING_LEVEL_check in theget_env_levelfunction instead