Various improvements for startup performance #126

karlch · 2019-11-23T16:47:33Z

Various little tweaks to work on startup performance:

Replace some python modules by the Qt equivalent
Lazier logic in logging and manipulate
fastentrypoints hack

Bugs found were fixed on the fly.

Ideas for further improvement:

Lazy initialization of thumbnail mode
Further import cleanup or even lazy imports, we still spend ~50 % of the startup time on imports

See e.g. pypa/setuptools#510.

This allows to: * Pass less arguments to the constructor * Lazily create the expensive argument parser object

This command can be quite slow as it may start a git subprocess and is not required in every run.

This saves some imports not required in a regular vimiv session.

This seems to be slightly faster than the QStackedLayout and also cleaner as we add a widget to an existing layout, not a layout to a layout.

This signal is emitted before a mode is entered the first time. This makes it possible to initialize mode-related widgets, such as manipulate, only upon first entering, not upon startup.

All manipulate related widgets are now only created upon the first entering of manipulate mode. This speeds up startup.

This is where the commandline is located anyway and therefore cleans up the dependencies slightly.

As the modes are globals of the module, the _entered attribute is not reset after each end2end test.

This can easily be done using QDateTime and saves an import :)

Improves startup performance by delaying the initialization of all completion models to the point when they are needed.

This makes it easy to run subprocesses using Qt instead of python and should improve performance as we do not require the subprocess module.

The hack introduced in d33d5b3 emitting aboutToQuit prematurely actually leads to it being emitted twice. The better solution is to write in serial and handle the one emitting correctly.

This removes the need of the python subprocess module and somewhat cleans up the implementation. For general external commands with !, a sub-shell is no longer spawned. This now only applies with the `:spawn` command.

The actual module logger instances are now only created on an as-needed basis. To avoid repetition in writing the log, debug, info, ... functions some __setattr__ magic was used which may have to be reconsidered.

* The conversion of QBytesArray to string is not recognized correctly * Logger type has changed to LazyLogger

* External commands now expand *, ? and [abc] as expected using glob without requiring a sub-shell * \char is used for escaping in paths, not the slightly cryptic [char] of glob

karlch added 26 commits November 18, 2019 11:51

Use fastentrypoints to speed-up startup

549bf3f

See e.g. pypa/setuptools#510.

Simplify logic checking for existing keybindings

29a7e91

Move logic from commands.register to constructor

5a190dd

This allows to: * Pass less arguments to the constructor * Lazily create the expensive argument parser object

Do not always log version information

e49a02f

This command can be quite slow as it may start a git subprocess and is not required in every run.

Move debugging utilities to own module

b895373

This saves some imports not required in a regular vimiv session.

Correctly use xdg join for trash directories

9b2e745

Use QStackedWidget for image / thumbnail

aeb91f7

This seems to be slightly faster than the QStackedLayout and also cleaner as we add a widget to an existing layout, not a layout to a layout.

Refactor api.modes for emitting first_entered

cc09038

This signal is emitted before a mode is entered the first time. This makes it possible to initialize mode-related widgets, such as manipulate, only upon first entering, not upon startup.

Refactor manipulate for lazy initialization

cdc9148

All manipulate related widgets are now only created upon the first entering of manipulate mode. This speeds up startup.

Fix crash when transforming without valid pixmap

3cfbf36

Create commandline in gui.bar

a19b5ed

This is where the commandline is located anyway and therefore cleans up the dependencies slightly.

Fix end2end tests for mode first_entered

7de6e5d

As the modes are globals of the module, the _entered attribute is not reset after each end2end test.

Remove use of datetime module

55b8444

This can easily be done using QDateTime and saves an import :)

Remove unused logging.handlers import

449b005

Initialize completion models on commmand enter

8aee388

Improves startup performance by delaying the initialization of all completion models to the point when they are needed.

Add function to run shell command in QProcess

5c8330c

This makes it easy to run subprocesses using Qt instead of python and should improve performance as we do not require the subprocess module.

Use QProcess for git version information

b709d64

Write pixmaps on quit in serial

6f487ba

The hack introduced in d33d5b3 emitting aboutToQuit prematurely actually leads to it being emitted twice. The better solution is to write in serial and handle the one emitting correctly.

Use QProcess implementation for external commands

c726aa4

This removes the need of the python subprocess module and somewhat cleans up the implementation. For general external commands with !, a sub-shell is no longer spawned. This now only applies with the `:spawn` command.

Make logging lazier

af75559

The actual module logger instances are now only created on an as-needed basis. To avoid repetition in writing the log, debug, info, ... functions some __setattr__ magic was used which may have to be reconsidered.

Fix mypy

78330f9

* The conversion of QBytesArray to string is not recognized correctly * Logger type has changed to LazyLogger

Add contains_any utility method

f717738

Add function to escape for glob

aff26ae

Improve wildcard handling for paths and !external

829cf4a

* External commands now expand *, ? and [abc] as expected using glob without requiring a sub-shell * \char is used for escaping in paths, not the slightly cryptic [char] of glob

Fix mypy

49549d6

Update documentation for :spawn

43bb5e6

karlch merged commit 7a022f2 into master Nov 23, 2019

karlch deleted the startup_performance branch November 23, 2019 17:00

karlch mentioned this pull request Nov 23, 2019

Improve startup performance #124

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various improvements for startup performance #126

Various improvements for startup performance #126

karlch commented Nov 23, 2019

Various improvements for startup performance #126

Various improvements for startup performance #126

Conversation

karlch commented Nov 23, 2019