Minor bugfixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taonic
reviewed
Jan 29, 2019
manted
reviewed
Jan 29, 2019
manted
reviewed
Feb 5, 2019
manted
approved these changes
Feb 5, 2019
…locks and {noformat} blocks
karimatthews
force-pushed
the
minor-bugfixes
branch
from
bb0e632 to
f57a723
Compare
veera
reviewed
Feb 11, 2019
s4mli
reviewed
Feb 11, 2019
veera
reviewed
Feb 11, 2019
| }); | ||
|
|
||
| // TODO: Fix the code so this test can be unskipped | ||
| it.skip('does not apply bold formatting without an asterisk pair at the start of the phrase', function () { |
There was a problem hiding this comment.
As this PR fixes minor issue, why do you skip this test - was it existing issue?
There was a problem hiding this comment.
Yes, it was an existing issue. See the Note in the PR description.
s4mli
reviewed
Feb 11, 2019
veera
reviewed
Feb 11, 2019
veera
reviewed
Feb 11, 2019
veera
reviewed
Feb 11, 2019
veera
reviewed
Feb 11, 2019
s4mli
approved these changes
Feb 11, 2019
1 task
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix some minor bugs in the Jira to markdown library.
The primary issue addressed in this PR (and the reason for creating this fork) is the issue of intra-word formatting when Jira-flavoured markdown is converted into regular markdown.
Before Fix
phrase_with_underscoresin Jira markdown is transformed tophrase*with*underscoresin regular markdown. This would then be rendered so:This is not desirable behaviour, particularly for important content such as urls and emails.
In the other direction,
phrase*with*asterisksin regular markdown becomesphrase_with_asterisksin Jira markdown, which is rendered so:This is also undesirable.
After fix
This library should recognise the
*and_characters within words should not be transformed.Other Changes:
Note
There are two skipped test. My markdown expertise has so far proved insufficient for getting this case to pass. (When a snippet like
a**phrase**is converted from md to jira it will be formatted toa*phrase*.) I think this is acceptable bug to leave for now for two reasons:If someone can think of a fix or has a use case that suggests this really needs to be fixed please let me know.
References