Switch #41
Merged
Switch #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mensfeld
requested review from
nijikon,
mach-kernel,
pavlo-vavruk and
agwozdowski
nijikon
requested changes
Oct 27, 2017
CHANGELOG.md
Outdated
|
|
||
| - #37 - ack level for producer | ||
| - Gem bump | ||
| - Ruby 2.4.2 support | ||
| - Raw ruby-kafka driver is not replaced with delivery_boy |
README.md
Outdated
|
|
||
| - Thread safe | ||
| - Supports sync producer | ||
| - Supports async producer |
There was a problem hiding this comment.
We could changes this to Supports sync and async producers
README.md
Outdated
| config.kafka.seed_brokers = ['localhost:9092'] | ||
| config.raise_on_failure = true | ||
| config.deliver = true | ||
| config.kafka.seed_brokers = ['kafka://localhost:9092'] |
README.md
Outdated
|
|
||
| Unfortunately, it does not yet support independent forks, however you should be fine by looking at what we require. | ||
|
|
||
| Please run: | ||
|
|
||
| ```bash | ||
| bundle exec rake | ||
| bundle exec rspec spec |
There was a problem hiding this comment.
No need to pass spec, bundle exec rspec is enough
README.md
Outdated
|
|
||
| [](https://app.coditsu.io/karafka/repositories/waterdrop) | ||
|
|
||
| Each pull request must pass our quality requirements. To check if everything is as it should be, we use [Coditsu](https://coditsu.io) that combines multiple linters and code analyzers for both code and documentation. | ||
| Each pull request must pass our quality requirements. To check if everything is as it should be, we use [Coditsu](https://coditsu.io) that combinse multiple linters and code analyzers for both code and documentation. |
lib/water_drop/sync_producer.rb
Outdated
| # Sync producer for messages | ||
| SyncProducer = Class.new(BaseProducer) | ||
| # Sync producer for messages | ||
| Producer = SyncProducer |
There was a problem hiding this comment.
This is backwards compatibility?
There was a problem hiding this comment.
No. It is just an alias for convenience. 1.0 is totally not compatible with 0.4
There was a problem hiding this comment.
I would remove this, we should be strict, either SyncProducer or AsyncProducer imho.
nijikon
approved these changes
Nov 3, 2017
agwozdowski
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was hanging few days now. This changes the API so please go through readme as well.
@filiptepper feel free to review it as well.