added producer compression #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please update the readme as well? Then it would be super duper cool! |
|
You bet!
|
|
@filiptepper FYI Waterdrop has a small doc that is a art of the readme - you can update it this PR as well :) |
|
@mensfeld Happy to do that, but I'm not entirely sure what you mean? |
|
@filiptepper jest the README update with the new options described. We have list of config options here: https://github.com/karafka/waterdrop and would be great if you could describe the once you've added. That's all. |
|
@mensfeld 🤦♂️ I had that ready, just forgot to push. |
|
@filiptepper 🥇 - looks great, once travis is green, will merge. You want me to release or you do master? |
|
No need to rush the release, thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to leverage
ruby-kafka's built in compression. This change will not introduce any backward incompatibility since it sets defaults to not enabling compression.