Fix key partitioner to use bytesize instead of size for multi-byte characters#804
Open
Fix key partitioner to use bytesize instead of size for multi-byte characters#804
Conversation
…aracters Fixes #629 The key partitioner was using `#size` instead of `#bytesize` which could cause incorrect partition assignments for keys with multi-byte characters. Since Kafka works with byte arrays, the partitioner should use `#bytesize` to ensure correct partition assignment based on the actual byte length. Changes: - Updated lib/rdkafka/bindings.rb to use `str.bytesize` instead of `str.size` - Added comprehensive tests for multi-byte character handling - Updated CHANGELOG.md Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #629
The key partitioner was using
#sizeinstead of#bytesizewhich could cause incorrect partition assignments for keys with multi-byte characters. Since Kafka works with byte arrays, the partitioner should use#bytesizeto ensure correct partition assignment based on the actual byte length of the key.Changes
lib/rdkafka/bindings.rbto usestr.bytesizeinstead ofstr.sizein the partition key calculationspec/lib/rdkafka/producer_spec.rbCHANGELOG.mdTesting
Added two new test contexts:
🤖 Generated with Claude Code