Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add better error message to say which components conflict #511

Merged

Conversation

dragoncoder047
Copy link
Contributor

@dragoncoder047 dragoncoder047 commented Nov 14, 2024

Screenshot 2024-11-14 at 4 58 29 PM

previously, it would just say "duplicate property width" and you'd be left wondering which components conflict

Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kaplayjs/kaplay@511

commit: ad3c729

Copy link
Collaborator

@lajbel lajbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lajbel lajbel merged commit 0c77c1d into kaplayjs:master Nov 15, 2024
2 checks passed
dragoncoder047 added a commit to dragoncoder047/kaplay that referenced this pull request Nov 15, 2024
@dragoncoder047 dragoncoder047 deleted the better-duplicate-property-error-message branch November 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: DONE
Development

Successfully merging this pull request may close these issues.

2 participants