Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimisations #79

Merged
merged 6 commits into from
Apr 23, 2018
Merged

Optimisations #79

merged 6 commits into from
Apr 23, 2018

Conversation

adrianchifor
Copy link
Member

@adrianchifor adrianchifor commented Apr 20, 2018 •
edited
Loading

  • Switch to ujson for better json parsing performance
  • Use yaml.CSafeLoader if C bindings for yaml lib are available. Output does not change. I have omitted the yaml.CDumper usage for now as a fallback would change the compilation output.
  • Keep print consistent by using {}.format() instead of f"{}" (only 3.6+)
  • Light refactoring and removed unused function load_target_file

@adrianchifor adrianchifor merged commit 09e4864 into master Apr 23, 2018
@adrianchifor adrianchifor deleted the optimisations branch April 23, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaro ramaro ramaro approved these changes

@gburiola gburiola Awaiting requested review from gburiola

@ademariag ademariag Awaiting requested review from ademariag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianchifor @ramaro