Skip to content

Conversation

@kanutocd
Copy link
Owner

Description

Closes #1

PR to fix sample issue #1

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this with multiple Ruby versions (if applicable)
  • I have tested this with multiple Rails versions (if applicable)

Documentation

  • I have updated the documentation accordingly
  • I have added YARD documentation for new methods
  • I have updated the CHANGELOG.md
  • I have updated the README.md (if applicable)

Code Quality

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run RuboCop and fixed any style issues

Breaking Changes

If this is a breaking change, please describe the impact and migration path for users:

Additional Notes

Any additional information about the PR that reviewers should know.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] A sample issue. Not a bug but a design feature

3 participants