Feature/hellodata 1240 copy dashboards #47
Conversation
# Conflicts: # hello-data-deployment/hello-data-dc-superset/src/main/docker/Dockerfile
| @Transactional(readOnly = true) | ||
| public String findSupersetInstanceNameByContextKey(String contextKey) { | ||
| return findAllByModuleTypeAndKind(ModuleType.SUPERSET, ModuleResourceKind.HELLO_DATA_APP_INFO, | ||
| ch.bedag.dap.hellodata.commons.sidecars.resources.v1.appinfo.AppInfoResource.class).stream() |
There was a problem hiding this comment.
Do we have multiple Classes with same name?
There was a problem hiding this comment.
ah, I though so because of the fully qualified class-name.
| @@ -30,9 +30,11 @@ | |||
| "@Dalete faq": "FAQ löschen", | |||
| "@Dashboard": "Dashboard", | |||
| "@Dashboard Overview": "Dashboards", | |||
| "@Dashboard import-export": "Dashboard import-export", | |||
There was a problem hiding this comment.
Maybe better: 'Dashboard Import/Export'
| return Paths.get(System.getProperty("java.io.tmpdir"), "dashboards_upload", uploadFolder); | ||
| } | ||
|
|
||
| private void buildChunks(String binaryFileId, String filename, long totalChunks, long fileSize, Path destinationPath) throws IOException { |
There was a problem hiding this comment.
maybe name this method assembleChunks()
| throw new RuntimeException("The file is not supported. Upload canceled"); | ||
| } | ||
| writeChunksToFile(destinationPath, chunks); | ||
| deleteTempBinaryFileData(binaryFileId); |
There was a problem hiding this comment.
maybe this delete-method could be moved into the try/catch/finally of the listenForRequests-method, so it gets called even in case of an exception.
There was a problem hiding this comment.
Sure, no problem. But I need the binary file ID to be able to be deleted. So there might be a situation where the folder will remain....
| } | ||
|
|
||
| private void writeChunksToFile(Path destinationPath, List<File> chunks) throws IOException { | ||
| destinationPath.getParent().toFile().mkdirs(); |
There was a problem hiding this comment.
I'd maybe extract the mkdirs-call out of this method, so the method only writes the chunks
| bytesReadTotal += bytesRead; | ||
| boolean isLastChunk = bytesReadTotal == file.getSize(); | ||
| log.info("Sending file to superset, bytes read total: {}, file size: {}", bytesReadTotal, file.getSize()); | ||
| DashboardUpload dashboardUpload = new DashboardUpload(buffer, ++chunkNumber, fileName, binaryFileId, isLastChunk, file.getSize()); |
There was a problem hiding this comment.
Just sth minor, but will there be a chunk with number 0 like this?
There was a problem hiding this comment.
ah, ok. it's just because normally we use zero-based indexing
No description provided.