Draft: Check return values for select statements#249
Open
felix-bedag wants to merge 2 commits intodevelopfrom
Open
Draft: Check return values for select statements#249felix-bedag wants to merge 2 commits intodevelopfrom
felix-bedag wants to merge 2 commits intodevelopfrom
Conversation
If they don't find anything with the strict keyword the function call fails. If this happens on a trigger, this means that all inserts on ab_permission_view fail if they don't concern DAGs. With this change also other permission_views can be inserted. Even though this change will not be applied where the migration already ran, it will be applied for new deployments, which is where the error appeared consistently
Contributor
Author
|
@wieczorslawo I inserted this change directly into the preexisting migration, as the one following it fails without. I wonder how it ever managed to run through... Do you have an idea? Since editing the preexisting migration doesn't really fix the other instances, do you think it would be good to insert a new migration recreating the trigger with the newest version too? I think that would be nice actually... |
Contributor
|
Hi @felix-bedag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the select statements don't find anything with the strict keyword the function call fails. If this happens on a trigger, this means that all inserts on ab_permission_view fail if they don't concern DAGs.
With this change also other permission_views can be inserted.
Even though this change will not be applied where the migration already ran, it will be applied for new deployments, which is where the error appeared consistently