Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trans/python vulnerability 2023 02 24 #74

Merged
merged 3 commits into from
Feb 26, 2023

Conversation

bourbonkk
Copy link
Contributor

@bourbonkk bourbonkk commented Feb 24, 2023

RSPEC-2076,RSPEC-2078,RSPEC-2083,RSPEC-2091,RSPEC-2115

여담이지만, 플라이 투 더 스카이 노래 너무 좋네요. 👍

@bourbonkk bourbonkk self-assigned this Feb 24, 2023
@bourbonkk bourbonkk requested a review from a team as a code owner February 24, 2023 10:49
Copy link
Contributor

@kok202 kok202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파이썬 진영이 앱 내부 로직으로 유독 쉘스크립트를 사용하거나 file I/O를 많이 사용하나보네요..?
관련된 보완 규칙이 유독 많네요

fly to the sky는 제 세대는 아니라서... 크흠.... 노래는 좋긴 하군요!

@app.route('/download')
def download():
file = request.args['file']
return send_file("static/%s" % file, as_attachment=True) # Noncompliant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일에
# 규칙을 어긴 코드
# 규칙을 준수한 해결책

번역이 빠진 듯 합니다

Copy link
Contributor

@GimunLee GimunLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.
플라이투더스카이 감성이 땡길 때가 있죠 ㅎㅎ

@bourbonkk
Copy link
Contributor Author

@kok202 피드백 반영했습니다 👍 리뷰 감사합니다

@bourbonkk bourbonkk merged commit 6df3584 into master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants