Skip to content

Commit

Permalink
RC-1: Iterative review support
Browse files Browse the repository at this point in the history
  • Loading branch information
evzijst committed Apr 15, 2010
1 parent 3f6f286 commit 62c1f03
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,14 @@ private boolean appendToReview(final String repoKey, final ChangesetDataFE cs, f
return false;
}

/**
* Note that this check is broken in Crucible older than 2.2. In 2.1, the
* review state gets stale and won't always show the current state.
* See: http://jira.atlassian.com/browse/CRUC-2912
*
* @param reviewIds
* @return
*/
private ReviewData getFirstOpenReview(Iterable<String> reviewIds) {

final Collection<ReviewData.State> acceptableStates = ImmutableSet.of(
Expand Down

0 comments on commit 62c1f03

Please sign in to comment.