Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept custom directories in the bump script #734

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Aug 14, 2020

Change Overview

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • #K10-5290

Test Plan

[11:55:24]tom@tom-XPS-15-9500: (bump-dir-params)~/src/kanister/ ./build/bump_version.sh 0.32.0 0.33.0 pkg
+ main 0.32.0 0.33.0 pkg
+ local prev=0.32.0
+ shift
+ local next=0.33.0
+ shift
+ '[' 1 -eq 0 ']'
+ pkgs=("$@")
+ grep -E 0.32.0 -r pkg
+ cut -d : -f 1
+ uniq
+ xargs sed -ri 's/0.32.0/0\.33\.0/g'
[11:55:32]tom@tom-XPS-15-9500: (bump-dir-params)~/src/kanister/ git diff --name-only
pkg/app/cassandra.go
pkg/app/mongodb.go
pkg/app/postgresql.go
pkg/blueprint/blueprints/rds-postgres-blueprint.yaml
pkg/function/data_test.go
pkg/function/export_rds_snapshot_location.go
pkg/function/kube_exec_test.go
pkg/function/kube_task_test.go
pkg/function/utils.go
pkg/kube/pod_test.go
pkg/param/param_test.go
pkg/testing/e2e_test.go
pkg/testutil/testutil.go

Update:
this is what we get now, if we runt his on k10

git status                                
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   docs/install/generic.rst
	modified:   go/src/kasten.io/k10/kio/dataservice/postgres/blueprint/blueprint.go
	modified:   go/src/kasten.io/k10/kio/names/const.go
	modified:   helm/k10-helm-operator/bundle/k10-helm-operator.clusterserviceversion.yaml
	modified:   helm/k10-helm-operator/deploy/crds/apik10.kasten.io_v1alpha1_k10_cr.yaml
	modified:   helm/k10-helm-operator/deploy/olm-catalog/k10-helm-operator/manifests/k10-helm-operator.clusterserviceversion.yaml
	modified:   helm/k10-helm-operator/helm-charts/k10/values.yaml
	modified:   helm/k10/values.yaml
	modified:   tools/kopia-benchmark/kopia_bench_job.yaml

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@viveksinghggits
Copy link
Contributor

viveksinghggits commented Sep 15, 2020

This looks good to me, I think we can merge this as it is.

that means . would imply to any character and that was the
reason we were seeing some unexpected behaviour.
This changes the flag to -F that matches the exact word.
@mergify mergify bot merged commit 95699dc into master Sep 17, 2020
@mergify mergify bot deleted the bump-dir-params branch September 17, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants