[chore] Upgrade kube version to v1.18.3 #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulchheda
force-pushed
the
upgrade_kube_version
branch
from
7d49245 to
a62cc22
Compare
viveksinghggits
force-pushed
the
upgrade_kube_version
branch
from
885c474 to
ea6857c
Compare
rahulchheda
force-pushed
the
upgrade_kube_version
branch
from
50d314b to
4841ef4
Compare
rahulchheda
requested review from
tdmanv,
viveksinghggits,
PrasadG193 and
pavannd1
and removed request for
tdmanv and
viveksinghggits
pavannd1
reviewed
Jul 27, 2020
|
Still have around 30+ files to go through. Looks good so far. |
rahulchheda
force-pushed
the
upgrade_kube_version
branch
3 times, most recently
from
e5fa53a to
b29eaab
Compare
pavannd1
reviewed
Aug 5, 2020
added 6 commits
August 6, 2020 13:44
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
Signed-off-by: Rahul M Chheda <rchheda@infracloud.io>
rahulchheda
force-pushed
the
upgrade_kube_version
branch
from
e2ee7ce to
0fe5198
Compare
tdmanv
approved these changes
Aug 6, 2020
10 tasks
Comment on lines
+125
to
132
| if _, err := cli.CrV1alpha1().ActionSets(ns).List(context.TODO(), v1.ListOptions{}); err != nil { | ||
| return errors.Wrap(err, "Could not list ActionSets") | ||
| } | ||
| if _, err := cli.CrV1alpha1().Blueprints(ns).List(v1.ListOptions{}); err != nil { | ||
| if _, err := cli.CrV1alpha1().Blueprints(ns).List(context.TODO(), v1.ListOptions{}); err != nil { | ||
| return errors.Wrap(err, "Could not list Blueprints") | ||
| } | ||
| if _, err := cli.CrV1alpha1().Profiles(ns).List(v1.ListOptions{}); err != nil { | ||
| if _, err := cli.CrV1alpha1().Profiles(ns).List(context.TODO(), v1.ListOptions{}); err != nil { | ||
| return errors.Wrap(err, "Could not list Profiles") |
There was a problem hiding this comment.
@A-kanksh-a I don't think we have handled this in the PR that you raised. In this case we can atleast, create context once and then pass that context to the other calls. Instead of creating the context n times.
There was a problem hiding this comment.
try to do this for every other occurance.
There was a problem hiding this comment.
@viveksinghggits I agree we can do this. we haven't handled this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan