Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade docker-cli to v1.18 #718

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Downgrade docker-cli to v1.18 #718

merged 2 commits into from
Jul 15, 2020

Conversation

tdmanv
Copy link
Contributor

@tdmanv tdmanv commented Jul 14, 2020

Change Overview

Use alpine3.10 instead of 3.12 to select an earlier version of the docker cli. This will unblock an issue where older versions of the docker daemon could not release Kanister.

Build log: https://gist.github.com/ad4c7e3e1b0838f010ce4965bca84783

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

docker run --rm -it kan
isterio/build:v0.0.11 sh
/ # docker version
Client:
 Version:           18.09.8-ce
 API version:       1.39
 Go version:        go1.12.6
 Git commit:        0dd43dd87fd530113bf44c9bba9ad8b20ce4637f
 Built:             Sat Jul 20 15:20:06 2019
 OS/Arch:           linux/amd64
 Experimental:      false
  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@tdmanv tdmanv added the kueue label Jul 15, 2020
@mergify mergify bot merged commit bbe17e8 into master Jul 15, 2020
@mergify mergify bot deleted the downgrade-docker branch July 15, 2020 20:07
@viveksinghggits
Copy link
Contributor

Hey @tdmanv
so the logs said

Error response from daemon: client version 1.40 is too new. Maximum supported API version is 1.37
: exit status 1

but even after this change, looking the the output that you have provided it seems the API version is still 1.39 (>1.37), not sure if thats gonna work.

rahulchheda pushed a commit that referenced this pull request Jul 21, 2020
* Downgrade docker-cli to v1.18

* Remove GOPATH from test script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants