Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic client to create volume snapshots #629

Merged
merged 9 commits into from
Mar 20, 2020
Merged

Use dynamic client to create volume snapshots #629

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
80b5f16
Use dynamic client to create volume snapshots
PrasadG193 Mar 16, 2020
624bae7
Remove external-snapshotter dep from kube/volume
PrasadG193 Mar 17, 2020
836e991
Add GetVolumeSnapshotClass to snapshotter
PrasadG193 Mar 18, 2020
a8e8be3
Move resource constant to snapshot/api packages
PrasadG193 Mar 18, 2020
9831662
Fix golint issue
PrasadG193 Mar 18, 2020
64cfebc
Fix missing namespace in content spec
PrasadG193 Mar 19, 2020
6eadbaf
Address review comments
PrasadG193 Mar 19, 2020
f7c6631
Addressed review comment
PrasadG193 Mar 19, 2020
7787472
Merge branch 'master' into snapshot-dyn-client
mergify[bot] Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix missing namespace in content spec 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
  • Loading branch information
@PrasadG193
PrasadG193 committed Mar 19, 2020
commit 64cfebcdf8c507cbddd7f868b48ae6efffdc62f3
2 changes: 1 addition & 1 deletion pkg/kube/snapshot/snapshot_alpha.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func (sna *SnapshotAlpha) CreateFromSource(ctx context.Context, source *Source,
"volumeSnapshotRef": map[string]interface{}{
"kind": VolSnapKind,
"name": snapshotName,
"namespace": snapshotName,
"namespace": namespace,
},
"snapshotClassName": source.VolumeSnapshotClassName,
"deletionPolicy": deletionPolicy,
Expand Down