Handle Namespace/ServiceAccount defaults in PodRunner #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksinghggits
force-pushed
the
podrunner-override-pod
branch
from
e7a382e to
a622ea5
Compare
PrasadG193
reviewed
Mar 26, 2020
|
Overall looks good. Please fix CI failure and suggested test case. |
PrasadG193
approved these changes
Mar 26, 2020
viveksinghggits
force-pushed
the
podrunner-override-pod
branch
2 times, most recently
from
fc2c8a3 to
08f3b1d
Compare
viveksinghggits
force-pushed
the
podrunner-override-pod
branch
from
067d3aa to
55b34d5
Compare
tdmanv
commented
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan