Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new method Resolve of kopia's fs.Symlink #3280

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

viveksinghggits
Copy link
Contributor

Change Overview

We have a mock type in kanister that implements kopia's fs.Symlink interface. Since this interface was recently modified to have a new method the mock type that we have in Kanister started to not implement that.
This commit makes sure that we add a dummy implementation of the type.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

We have a mock type in kanister that implements kopia's `fs.Symlink`
interface. Since this interface was recently modified to have a new
method the mock type that we have in Kanister started to not implement
that.
This commit makes sure that we add a dummy implementation of the
type.
pkg/virtualfs/symlink.go Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented Dec 9, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #3280 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: Required status check "DCO" is action required.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@pavannd1 pavannd1 added kueue and removed kueue labels Dec 9, 2024
@pavannd1
Copy link
Contributor

pavannd1 commented Dec 9, 2024

@Mergifyio requeue

Copy link
Contributor

mergify bot commented Dec 9, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@pavannd1 pavannd1 added kueue and removed kueue labels Dec 9, 2024
Copy link
Contributor

mergify bot commented Dec 9, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #3280 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

  • all of:
    • label=kueue.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit 57d669a into master Dec 9, 2024
25 checks passed
@mergify mergify bot deleted the fix-kopia-fssymlink branch December 9, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants