Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove extra argument from check calls #2728

Merged
merged 3 commits into from
Mar 7, 2024
Merged

test: remove extra argument from check calls #2728

merged 3 commits into from
Mar 7, 2024

Conversation

hairyhum
Copy link
Contributor

@hairyhum hairyhum commented Mar 7, 2024

Change Overview

Don't pass test suite as an argument to the check asserts.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@hairyhum hairyhum requested a review from plar March 7, 2024 18:26
@hairyhum hairyhum marked this pull request as ready for review March 7, 2024 18:51
@hairyhum hairyhum added the kueue label Mar 7, 2024
@mergify mergify bot merged commit f27ff46 into master Mar 7, 2024
14 checks passed
@mergify mergify bot deleted the test-extra-arg branch March 7, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveksinghggits viveksinghggits viveksinghggits approved these changes

@plar plar Awaiting requested review from plar

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairyhum @viveksinghggits