Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow to build and push MongoDB Atlas tools image #2038

Merged
merged 4 commits into from
May 9, 2023

Conversation

shahpratikr
Copy link
Contributor

Change Overview

This PR adds automation to create mongodb-atlas image to ghcr.io registry.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link
Contributor

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@viveksinghggits
Copy link
Contributor

@shahpratikr
We were not planning to build the image and publish it using kanister right? Did we change that?

@shahpratikr shahpratikr force-pushed the pratik/mongodb-atlas-support branch from 6282a7b to 7bc117f Compare May 2, 2023 07:30
@shahpratikr shahpratikr force-pushed the pratik/add_atlas_image branch from c8efbf0 to 2426602 Compare May 2, 2023 07:33
@shahpratikr
Copy link
Contributor Author

@shahpratikr We were not planning to build the image and publish it using kanister right? Did we change that?

We discussed that for E2E tests, we will need to build image. hence added this change to build atlas image as well

@shahpratikr shahpratikr force-pushed the pratik/mongodb-atlas-support branch from 3c625e8 to 936fb34 Compare May 2, 2023 07:37
@shahpratikr shahpratikr force-pushed the pratik/add_atlas_image branch from 2426602 to 36a8382 Compare May 2, 2023 07:38
Base automatically changed from pratik/mongodb-atlas-support to master May 2, 2023 08:22
@shahpratikr shahpratikr force-pushed the pratik/add_atlas_image branch from 36a8382 to 5de8080 Compare May 2, 2023 08:37
@shahpratikr shahpratikr force-pushed the pratik/add_atlas_image branch from 5de8080 to e8437e2 Compare May 5, 2023 06:24
@shahpratikr shahpratikr changed the title Add mongodb-atlas image to ghcr.io registry Add github workflow to build and push MongoDB Atlas tools image May 8, 2023
Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. We can merge this once we decide that we really want this in E2E.

.github/workflows/atlas-image-build.yaml Outdated Show resolved Hide resolved
.github/workflows/atlas-image-build.yaml Show resolved Hide resolved
@shahpratikr shahpratikr force-pushed the pratik/add_atlas_image branch from b18a58b to e887e6a Compare May 9, 2023 05:23
@shahpratikr shahpratikr added kueue and removed kueue labels May 9, 2023
@julio-lopez julio-lopez removed the kueue label May 9, 2023
@julio-lopez julio-lopez enabled auto-merge (squash) May 9, 2023 16:16
@julio-lopez julio-lopez merged commit b9eee33 into master May 9, 2023
@julio-lopez julio-lopez deleted the pratik/add_atlas_image branch May 9, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants