Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed image values for MongoDB and PostgresDB charts in integration tests #1831

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

shahpratikr
Copy link
Contributor

@shahpratikr shahpratikr commented Jan 2, 2023

Change Overview

  • removed usage of kanister images while installing MongoDB and PostgresDB helm charts
  • fixed minor issues in formatting

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Ran integration tests for Mongodb and Postgresql using following commands
./build/integration-test.sh ^PostgreSQL$ and ./build/integration-test.sh ^MongoDB$

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@PrasadG193
Copy link
Contributor

@shahpratikr could you please add the test plan?

@shahpratikr
Copy link
Contributor Author

@shahpratikr could you please add the test plan?

added

Copy link
Contributor

@akankshakumari393 akankshakumari393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@viveksinghggits viveksinghggits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment, otherwise looks good.

@shahpratikr shahpratikr force-pushed the pratik/remove_kanister_images branch from b517f3d to 2e554c2 Compare January 3, 2023 04:47
Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we should create two different PRs when changes are done to different workflows/examples, etc. It makes reviewing easier and reverts too in case of issues in one workflow.

pkg/app/postgresql-deploymentconfig.go Show resolved Hide resolved
pkg/app/rds_postgres.go Show resolved Hide resolved
pkg/app/rds_postgres.go Show resolved Hide resolved
pkg/app/rds_postgres.go Show resolved Hide resolved
… tests

- removed usage of kanister images while installing MongoDB and PostgresDB
helm charts
- fixed minor issues in formatting
@shahpratikr shahpratikr force-pushed the pratik/remove_kanister_images branch from 2e554c2 to 742008b Compare January 4, 2023 07:01
@mergify mergify bot merged commit 002a81d into master Jan 4, 2023
@mergify mergify bot deleted the pratik/remove_kanister_images branch January 4, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants