feat(card): attach files directly when creating a card - #548
Open
HeinrichNebula wants to merge 1 commit into
Open
feat(card): attach files directly when creating a card#548HeinrichNebula wants to merge 1 commit into
HeinrichNebula wants to merge 1 commit into
Conversation
The new-card form only supported title/description; attachments required creating the card first and reopening it. Files can now be queued in the form (picker button or drag and drop), are uploaded sequentially to the existing /api/upload/attachment endpoint once the card is created, and failures surface via popup without rolling back the card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The new-card modal only supports title/description/labels/members/due date. Attaching a file requires creating the card first, reopening it, and uploading there. This PR lets users queue files in the create form itself:
/api/upload/attachmentendpoint, followed by a board invalidationAlso removes duplicate
comments/checklists/attachmentskeys in the optimistic card payload in the same file (TS1117, a hard error undertsc --noEmit).Notes
tmacrosTesting