swift: Remove swift 2 (no longer testable). - #688
Merged
Merged
Conversation
29 tasks
Contributor
|
Sure, it makes complete sense to get rid of this version. I don't think it provides any benefit. I'm amazed you've kept it around this long. :-) |
Owner
Author
|
@keith-rollin okay, done! It was one of the older implementations so I had some nostalgia for it TBH. I did add it to the "Others / Alternate implementations" section with a link to the version before this PR. Ready to do another implementation almost a decade later? Fortran is ripe for the picking :-D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the Swift 2 ("swift") implementation from the repo :-(
We haven't had the Swift 2 implementation running in CI for a while (ever since the transition from Travis CI to GHA) because there are no Github Actions runners that support it. In addition, the implementation generates the incremental step files from a single source file which makes the primary source file and the resulting build process fairly complicated compared to other implementations.
We are in the process of updating all implementations to use a simpler eval process (no separate
eval_ast) and much simplified macro handling. The non-standard layout of this implementation along with the inability to build/test this implementation is why I've created this PR to remove it.@keith-rollin, as the original author, I would like to give you the opportunity to weigh in. If you are able to do the work to get this building/testable in GHA/CI and also simplify the build process (i.e. split the steps into true original steps), then I would be willing to keep this implementation in the repo (at least until Swift 2 binaries are no longer available for download). I'll keep this open for a week or two so that you have the opportunity to weigh in. Let me know what you think.
Notes on my own attempt to get this to build in a docker container:
There are still packages for Swift 2 here: https://www.swift.org/download/ (under "Older Release"). I've attempted to build a Linux docker image using 2.2.1 based on Ubuntu 14.04. I copied the current Dockerfile image for swift3 and updated it to use ubuntu:14.04 and download 2.2.1 binary image.
I had to tweak the Makefile like this to get things attempting to build at all:
However, even with those changes, the build fails with: