Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for useBuildNumber parameter in the check method. #1

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

iamriajul
Copy link

No description provided.

@kamranbekirovyz
Copy link
Owner

Thanks for the PR @iamriajul!

What do you think if we add it using VersionarteComparator enum? And also if we're comparing using build number, I guess we need to add some documentation hints for the JSON structure.

@iamriajul
Copy link
Author

Thanks for the PR @iamriajul!

What do you think if we add it using VersionarteComparator enum? And also if we're comparing using build number, I guess we need to add some documentation hints for the JSON structure.

Good suggestion, Thanks. I'll try to add some documentation and VersionarteComparator soon.

@kamranbekirovyz
Copy link
Owner

@iamriajul thanks for the new commits, I'll check ASAP.

@kamranbekirovyz
Copy link
Owner

@iamriajul I'm planning to merge this for versionarte 1.0.0, should be soon..

# Conflicts:
#	README.md
#	lib/src/versionarte.dart
@kamranbekirovyz
Copy link
Owner

@iamriajul salam. I've been awaiting this PR for a long time because I needed some time to update the documentation with proper information that people don't confuse it. I'll look at this next inshallah. Thanks for your time.

BTW, I'm using adhan_dart in my https://beyt.app mobile app. Thanks for that

@iamriajul
Copy link
Author

@iamriajul salam. I've been awaiting this PR for a long time because I needed some time to update the documentation with proper information that people don't confuse it. I'll look at this next inshallah. Thanks for your time.

BTW, I'm using adhan_dart in my https://beyt.app mobile app. Thanks for that

@kamranbekirovyz waalaikum as-salam, glad to hear that you're using adhan_dart. I just installed the app, The UX/UI is great, and I loved it.

@kamranbekirovyz
Copy link
Owner

@iamriajul salam. I've been awaiting this PR for a long time because I needed some time to update the documentation with proper information that people don't confuse it. I'll look at this next inshallah. Thanks for your time.
BTW, I'm using adhan_dart in my https://beyt.app mobile app. Thanks for that

@kamranbekirovyz waalaikum as-salam, glad to hear that you're using adhan_dart. I just installed the app, The UX/UI is great, and I loved it.

Thanks 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants