Skip to content

Commit

Permalink
Minor lint fixes.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 569597009
  • Loading branch information
hongted authored and copybara-github committed Sep 29, 2023
1 parent e080341 commit 669fc87
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 9 deletions.
2 changes: 1 addition & 1 deletion docs_src/bazel_rules_macros.md
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ currently produced should be considered INCOMPLETE.
| :------------- | :------------- | :------------- |
| <a id="xls_delay_model_generation-name"></a>name | Used as basename for both the script and the output textproto. | none |
| <a id="xls_delay_model_generation-standard_cells"></a>standard_cells | Label for the PDK (possibly specifying a non-default corner), with the assumption that $location will return the timing (Liberty) library for the PDK corner. | none |
| <a id="xls_delay_model_generation-samples_file"></a>samples_file | <p align="center"> - </p> | none |
| <a id="xls_delay_model_generation-samples_file"></a>samples_file | Path to proto providing sample points. | none |
| <a id="xls_delay_model_generation-kwargs"></a>kwargs | Accepts add'l keyword arguments. Passed to native.genrule(). | none |
Expand Down
6 changes: 5 additions & 1 deletion xls/build_rules/elab_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

"""Build rules for elaboration tests."""

def elab_test(name, src, hdrs, top):
def elab_test(
name, # @unused
src, # @unused
hdrs, # @unused
top): # @unused
"""No elaboration / lint checking yet in OSS builds."""
pass
6 changes: 5 additions & 1 deletion xls/build_rules/py_proto_library.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@

load("@com_google_protobuf//:protobuf.bzl", "py_proto_library")

def xls_py_proto_library(name, internal_deps, srcs, deps = []):
def xls_py_proto_library(
name,
internal_deps, # @unused
srcs,
deps = []):
py_proto_library(
name = name,
srcs = srcs,
Expand Down
1 change: 1 addition & 0 deletions xls/build_rules/xls_macros.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,7 @@ def xls_delay_model_generation(
standard_cells: Label for the PDK (possibly specifying a
non-default corner), with the assumption that $location will
return the timing (Liberty) library for the PDK corner.
samples_file: Path to proto providing sample points.
**kwargs: Accepts add'l keyword arguments. Passed to native.genrule().
"""
native.genrule(
Expand Down
2 changes: 1 addition & 1 deletion xls/build_rules/xls_oss_config_rules.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ CONFIG = {
},
}

def enable_generated_file_wrapper(**kwargs):
def enable_generated_file_wrapper(**kwargs): # @unused
"""The function is a placeholder for enable_generated_file_wrapper.
The function is intended to be empty.
Expand Down
10 changes: 5 additions & 5 deletions xls/build_rules/xls_rules_build_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ load(
"//xls/build_rules:xls_codegen_rules.bzl",
_xls_ir_verilog = "xls_ir_verilog",
)
load(
"//xls/build_rules:xls_jit_wrapper_rules.bzl",
_xls_ir_jit_wrapper = "xls_ir_jit_wrapper",
_xls_ir_jit_wrapper_macro = "xls_ir_jit_wrapper_macro",
)
load(
"//xls/build_rules:xls_ir_rules.bzl",
_xls_dslx_ir = "xls_dslx_ir",
_xls_ir_opt_ir = "xls_ir_opt_ir",
)
load(
"//xls/build_rules:xls_jit_wrapper_rules.bzl",
_xls_ir_jit_wrapper = "xls_ir_jit_wrapper",
_xls_ir_jit_wrapper_macro = "xls_ir_jit_wrapper_macro",
)
load(
"//xls/build_rules:xls_rules.bzl",
_xls_dslx_opt_ir = "xls_dslx_opt_ir",
Expand Down

0 comments on commit 669fc87

Please sign in to comment.