Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If upstream and downstream are mixed, the orientation is incorrect. #145

Closed
fealone opened this issue Nov 6, 2020 · 2 comments · Fixed by #156
Closed

If upstream and downstream are mixed, the orientation is incorrect. #145

fealone opened this issue Nov 6, 2020 · 2 comments · Fixed by #156
Labels
bug Something isn't working package:@rediagram/cdk Component Development Kit for rediagram library.

Comments

@fealone
Copy link

fealone commented Nov 6, 2020

Describe the bug
If upstream and downstream are mixed, the orientation described earlier has priority.

  • Example code
<AppEngine
    name="ExampleA"
    upstream={["ExampleB"]}
    downstream={["ExampleB"]}
/>
  • Expected diagram

ExampleA -> ExampleB
ExampleA <- ExampleB

  • Actual diagram

ExampleA -> ExampleB
ExampleA -> ExampleB

@fealone fealone added the bug Something isn't working label Nov 6, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@kamiazya kamiazya added the package:@rediagram/cdk Component Development Kit for rediagram library. label Nov 10, 2020
@kamiazya
Copy link
Owner

In the current implementation, the direction of the downstream arrow is semantically incorrect.

To solve this problem, we have to make changes that make the drawing backward incompatible.

Also, to maintain functional compatibility, it is necessary to have an option to specify the placement when specifying downstream or upstream.

The option to allow bidirectional resolution resolves #144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:@rediagram/cdk Component Development Kit for rediagram library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants