send application event analytics beacon for custom reports #13723
+62
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-copilot suggest |
use requestUtils::sendAnalyticsBeacon
|
@github-copilot suggest |
inbal-ben-david
approved these changes
Dec 25, 2025
| } | ||
|
|
||
| protected static function getCustomReportAnalyticsEventContent($id, $params, $partner_id) | ||
| { |
Collaborator
There was a problem hiding this comment.
Consider adding sanitization and size limits to $params
| { | ||
| $stats_host = explode(':', kConf::get(self::INTERNAL_ANALYTICS_HOST)); | ||
| $customReportEventContent = self::getCustomReportAnalyticsEventContent($id, $params, $partner_id); | ||
| requestUtils::sendAnalyticsBeacon( |
Collaborator
There was a problem hiding this comment.
Can sendAnalyticsBeacon throw exception? if so please wrap it with try/catch and proper handler
| $api_info = ''; | ||
| foreach ($params as $key => $value) | ||
| { | ||
| if ($key != 'partner_id') |
Collaborator
There was a problem hiding this comment.
use const for partner_id
|
|
||
| if (kConf::hasParam(self::INTERNAL_ANALYTICS_HOST)) | ||
| { | ||
| $stats_host = explode(':', kConf::get(self::INTERNAL_ANALYTICS_HOST)); |
Collaborator
There was a problem hiding this comment.
lets validate that $stats_host array length is 2 to avoid exception
| requestUtils::sendAnalyticsBeacon( | ||
| $customReportEventContent, | ||
| $stats_host[0], | ||
| isset($stats_host[1]) ? $stats_host[1] : 80 |
Collaborator
There was a problem hiding this comment.
use const for default http port 80
|
@github-copilot suggest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please complete the following before submitting:
General notes -
New Kaltura Types
New Kaltura Services / Actions
Questions
What is the purpose of this PR?
Does this change affect production code or infrastructure?
If yes, what is the rollback plan?