SUP-50712: if partner has getEnforceHttpsApi then set protocol to https #13713
Conversation
|
@github-copilot suggest |
There was a problem hiding this comment.
Pull request overview
This PR enforces HTTPS protocol for thumbnail URLs when a partner has the enforceHttpsApi flag enabled. The change ensures that entries belonging to partners requiring HTTPS will have their thumbnail URLs generated with the HTTPS protocol.
- Adds partner-level HTTPS enforcement check for thumbnail URL generation
- Passes protocol parameter to
getThumbnailUrl()when HTTPS is enforced
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@github-copilot suggest |
|
@github-copilot suggest |
MaimanaGhnem
requested review from
MosheMaorKaltura,
inbal-ben-david and
shahbaa123
| else | ||
| { | ||
| $assetUrl = kAssetUtils::getAssetUrl($thumbAsset); | ||
| $assetUrl = self::enforceHttpsIfRequired($thumbAsset->getPartnerId(),$assetUrl); |
There was a problem hiding this comment.
missing space after come
| { | ||
| $cdnUrl = $cdnUrlPartners[$thumbAsset->getPartnerId()]; | ||
| $assetUrl = kAssetUtils::getAssetUrl($thumbAsset, false, null, null, '', $cdnUrl); | ||
| $assetUrl = self::enforceHttpsIfRequired($thumbAsset->getPartnerId(),$assetUrl); |
There was a problem hiding this comment.
missing space after come
| $partner = PartnerPeer::retrieveByPK($partnerId); | ||
| if ($partner && $partner->getEnforceHttpsApi()) | ||
| { | ||
| $url = str_replace('http://', 'https://', $url); |
There was a problem hiding this comment.
In case the URL contains http:// more than once, better limit it to the first occurance
if (strpos($url, 'http://') === 0)
{
$url = 'https://' . substr($url, 7);
}
Pull Request Checklist
Please complete the following before submitting:
General notes -
New Kaltura Types
New Kaltura Services / Actions
Questions
What is the purpose of this PR?
Does this change affect production code or infrastructure?
If yes, what is the rollback plan?