PLAT-25496 - Support multiple values for url_token_secret #13575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-copilot suggest |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for multiple URL token secrets to enhance token validation flexibility. The changes allow the system to maintain backwards compatibility while supporting multiple secret values for URL token generation and validation.
Key changes:
- Modified token generation to use the current secret from a collection of secrets
- Updated token validation to check against all available secrets instead of just one
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| alpha/lib/model/flavorAsset.php | Updates token generation to use getCurrentSecret() instead of get() |
| alpha/apps/kaltura/modules/extwidget/actions/playManifestAction.class.php | Enhances token validation to iterate through all available secrets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| $secrets = kConf::getAllSecrets('url_token_secret'); | ||
| foreach ($secrets as $secret) { | ||
| $calcToken = sha1($secret . $url); | ||
| if ($calcToken == $urlToken) { |
There was a problem hiding this comment.
Use strict comparison (===) instead of loose comparison (==) for token validation to prevent type juggling attacks and ensure exact string matching.
Suggested change
| if ($calcToken == $urlToken) { | |
| if ($calcToken === $urlToken) { |
rkreich
force-pushed
the
PLAT-25493-RemoteAddrHeaderSalt
branch
from
17644a7 to
b08727c
Compare
rkreich
force-pushed
the
PLAT-25496-UrlTokenSecret
branch
from
c3a6d8f to
b330ea4
Compare
|
@github-copilot suggest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.