feat(FEC-10160): filter unsupported formats from the configured tracks passed to the receiver #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yairans
changed the title
dan-ziv
reviewed
Jun 28, 2020
| language: caption.language | ||
| }); | ||
| return newTrack; | ||
| if (this._playerConfig.sources.captions && this._playerConfig.sources.captions.length) { |
There was a problem hiding this comment.
LGTM.
But I would export all the external captions handling to a separate method since _getLoadOptions start to become unreadable.
dan-ziv
reviewed
Jun 28, 2020
src/cast-player.js
Outdated
| return loadOptions; | ||
| } | ||
|
|
||
| _handleExternalCaptions() { |
There was a problem hiding this comment.
This method returns the external captions, so _getExternalCaptions
5 tasks
yairans
added a commit
to kaltura/playkit-js-cast-receiver
that referenced
this pull request
Jun 28, 2020
…s passed to the receiver (#28) check track existence before selection Related to kaltura/playkit-js-cast-sender#38 Solves FEC-10160
OrenMe
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Pass to the receiver
vttonlyRelated to kaltura/playkit-js-cast-receiver#28
Solves FEC-10160
CheckLists