Skip to content

Fix a potential bug in carpa when calculating backoff logprob #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Fix a potential bug in carpa when calculating backoff logprob #4195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed12bae
remove the edge in the lattice if the smaller ngram in recursion does…
Jul 28, 2020
f9c9359
change the prob for <unk> from min() to -infinity()
Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lm/const-arpa-lm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ float ConstArpaLm::GetNgramLogprobRecurse(
// If <unk> is defined, then the word sequence should have already been
// mapped to <unk> is necessary; this is for the case where <unk> is not
// defined.
return std::numeric_limits<float>::min();
return -std::numeric_limits<float>::infinity();
} else {
Int32AndFloat logprob_i(*unigram_states_[word]);
return logprob_i.f;
Expand Down Expand Up @@ -1034,7 +1034,7 @@ bool ConstArpaLmDeterministicFst::GetArc(StateId s,
std::vector<Label> wseq = state_to_wseq_[s];

float logprob = lm_.GetNgramLogprob(ilabel, wseq);
if (logprob == std::numeric_limits<float>::min()) {
if (logprob == -std::numeric_limits<float>::infinity()) {
return false;
}

Expand Down