TS-VAD based diarization in CHiME-6

[desh2608]

The implementation is from @ipmedenn and it has also been tested by @aarora8 and me.

[kkm000]

Desh, mostly code formatting and code style nits. I did not duplicate stuff like spacing around operators, code looks like it has been copypasted, so most comments to multiply.cc apply to paste.cc.

[desh2608]

@kkm000 thanks for the detailed comments! @ipmedenn could you make these changes when you have some time?

[ipmedenn]

@kkm000 thanks for the detailed comments! @ipmedenn could you make these changes when you have some time?

@desh2608 yes I will. Should I make it in kaldi_chime6 repo or in https://github.com/desh2608/kaldi/tree/ts_vad_final?

[desh2608]

@kkm000 thanks for the detailed comments! @ipmedenn could you make these changes when you have some time?

@desh2608 yes I will. Should I make it in kaldi_chime6 repo or in https://github.com/desh2608/kaldi/tree/ts_vad_final?

@ipmedenn You can push it to this branch (ts_vad_final) so that this PR will get updated automatically.

[danpovey]

I think paste- is fine for the name, for consistency; just change the error message to clarify what it actually does.

…

On Fri, Jul 17, 2020 at 9:08 PM kkm000 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/featbin/paste-vectors.cc <#4164 (comment)>: > + in[i].Range(0, this_dim)); + dim_offset += this_dim; + } + return true; +} + + +} + +int main(int argc, char *argv[]) { + try { + using namespace kaldi; + using namespace std; + + const char *usage = + "Paste vector files \n" @danpovey <https://github.com/danpovey>, I'm kinda torn on this, the naming would be inconsistent either. We already have binaries with a similar semantics called paste-*, and dissimilar called concat-*. Maybe combine-vectors would work? Yes, of course I understand these are not usually text files. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4164 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZFLO3AFXTIAVDTMEAIAD3R4BENPANCNFSM4OY6YCCA> .

[ipmedenn]

@kkm000 thanks for the detailed comments! @ipmedenn could you make these changes when you have some time?

@desh2608 yes I will. Should I make it in kaldi_chime6 repo or in https://github.com/desh2608/kaldi/tree/ts_vad_final?

@ipmedenn You can push it to this branch (ts_vad_final) so that this PR will get updated automatically.

@desh2608 it seems that I have no permission to commit in your repo

[desh2608]

I believe all the comments have now been addressed by @ipmedenn.

[ipmedenn]

@kkm000 check the updated versions, please.

[kkm000]

@ipmedenn, Thanks, I'll do my best to review today.

[kkm000]

Thanks, almost there. We only need to add a sensible usage message, and handle the case of non-ark: input (print an error).

[ipmedenn]

@kkm000 Thank you! I've made these changes. @desh2608 could you merge my PR to your repo?

[kkm000]

LGTM, thanks guys, merging this!