-
Notifications
You must be signed in to change notification settings - Fork 5.4k
[src] CudaDecoder endpointing #4146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! So, you'd say that both #4101 and this one are ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two of my comments to the other PR no longer apply. I'll mark them there.
@kkm000 The known issue was fixed and we don't have any known bugs now |
Thanks much! Merging. |
A bug happened in this commit
|
Built on top of #4101. Probably better to look at the diff once #4101 has been merged.
Implements endpointing directly into the cuda decoder.
Uses the rules as defined in online2/online-endpoint.h. From a user point of view, setting the high level parameters on endpointing and passing a vector in the DecodeBatch should be enough:
Parameters (from online2/online-endpoint.h):
Easiest way to test is to pass
--print-endpoints=true
to the binarysrc/cudadecoderbin/batched-wav-nnet3-cuda-online
Internally, it provides all the necessary metrics (relative cost, number of silence phones on current best path, total length). Those rules can be modified through the command line parameters.