Add PortAudio to Windows generate_solution.pl #4026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized this overwrites fst.lib and blas directories. While it builds, it does not build correctly. Have confirmed it builds correctly when not overwritten. Will fix script. |
|
Builds correctly. |
|
@jtrmal could you please merge this if you think it's OK? |
jtrmal
reviewed
Apr 7, 2020
|
will do.
…On Tue, Apr 7, 2020 at 3:31 AM Daniel Povey ***@***.***> wrote:
@jtrmal <https://github.com/jtrmal> could you please merge this if you
think it's OK?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4026 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUKYX5TK7UFVCGANFLZU7TRLLJGTANCNFSM4L4TLE7Q>
.
|
|
Cool, thanks a lot |
pc-seawind
pushed a commit
to pc-seawind/kaldi
that referenced
this pull request
Jun 4, 2020
…-asr#4026) * Add portaudio build instructions. Need to test on a clean kaldi pull. * Correct location of portaudio.props * Small edit to INSTALL.md * Fix portaudio directory * Change paths back to match readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds PortAudio dependencies to the Visual Studio sln generator script, and provides instructions in INSTALL.md on how to produce a compatible build in PortAudio.