Adding GetSamplingFrequency to OnlineNnet2FeaturePipelineInfo #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovbraun
force-pushed
the
get_model_freq_feat_pipelines_info
branch
from
667a2f0 to
9adc64c
Compare
|
How about add it in online feature interface? |
danpovey
reviewed
Feb 19, 2020
| @@ -241,5 +241,17 @@ BaseFloat OnlineNnet2FeaturePipelineInfo::FrameShiftInSeconds() const { | |||
| } | |||
| } | |||
|
|
|||
| BaseFloat OnlineNnet2FeaturePipelineInfo::GetModelFrequency() { | |||
There was a problem hiding this comment.
Please call this GetSamplingFrequency()
|
mm, I see your point Xingyu, but for now I don't want to make big changes
to that code, I'm mostly focused on newer code, so let's make the change
small.
…On Wed, Feb 19, 2020 at 10:07 AM Xingyu Na ***@***.***> wrote:
How about add it in online feature interface?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3939?email_source=notifications&email_token=AAZFLO4KFLKLPFQR7BEGRWTRDSH6DA5CNFSM4KXO6KLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGCG2A#issuecomment-587998056>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZFLO7233FP7FSYHM3DCJ3RDSH6DANCNFSM4KXO6KLA>
.
|
|
I see. Cool.
On Wed, Feb 19, 2020 at 1:03 PM Daniel Povey <notifications@github.com>
wrote:
… mm, I see your point Xingyu, but for now I don't want to make big changes
to that code, I'm mostly focused on newer code, so let's make the change
small.
On Wed, Feb 19, 2020 at 10:07 AM Xingyu Na ***@***.***>
wrote:
> How about add it in online feature interface?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <
#3939?email_source=notifications&email_token=AAZFLO4KFLKLPFQR7BEGRWTRDSH6DA5CNFSM4KXO6KLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGCG2A#issuecomment-587998056
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAZFLO7233FP7FSYHM3DCJ3RDSH6DANCNFSM4KXO6KLA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3939?email_source=notifications&email_token=AAZKTRFVEX2WLJ77IL2DUX3RDS4TFA5CNFSM4KXO6KLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMGLZWY#issuecomment-588037339>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZKTRHXO57GLQZH2B37Z5LRDS4TFANCNFSM4KXO6KLA>
.
|
hugovbraun
force-pushed
the
get_model_freq_feat_pipelines_info
branch
from
9adc64c to
c6bf0e6
Compare
|
@danpovey updated |
hugovbraun
changed the title
hugovbraun
added a commit
to hugovbraun/kaldi
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an easy way to get the frequency associated with the feature config.