Fixed Path to Sequitur Executable #3932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if I have done something wrong. |
|
@jtrmal can you merge this? |
|
I'll check it out and merge today... I'm a bit suspicious about the path --
there might be something else going on as we didn't have any complaints in
the past
y.
…On Sun, Feb 16, 2020 at 10:41 PM Daniel Povey ***@***.***> wrote:
@jtrmal <https://github.com/jtrmal> can you merge this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3932?email_source=notifications&email_token=ACUKYXZSQSY6IGBHX36K4QDRDIBOLA5CNFSM4KWD3PCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL462SY#issuecomment-586804555>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUKYX2UC7VM2ND72JGKD4LRDIBOLANCNFSM4KWD3PCA>
.
|
|
Hi, I just verified on two system that the binary is installed into ${SEQUITUR}/bin... |
|
I initially got this error while installing sequitur on CentOS 7: I followed the instructions from the following link: Installation - Standard Output Log Installation - Standard Error Log There is no directory named |
|
It says: So I think your change addresses something after your tweaks, but in general, it wouldn't be correct. |
|
Actually, I'm trying to figure out a more robust way how to install sequitur... Could you check out the original script (without your changes) and apply this simple diff? Thanks! |
|
Sorry about not spotting that change. And Yes, Will check out the script with the diff and let you know. |
|
Hi @jtrmal I had to change Check if it is the same with the rest of the systems or if numpy 1.18.1 will work with other systems. |
|
Cool! I'm glad it worked. I will fix the numpy reqs as well.
Y.
…On Thu, Feb 20, 2020 at 08:15 Vishal Rao ***@***.***> wrote:
Hi @jtrmal <https://github.com/jtrmal>
The diff you suggested worked.
I had to change requirements.txt to not use the latest version of numpy
(I used 1.16.4).
Using the latest version of numpy (1.18.1) was throwing an error because
of something similar to the following link:
https://stackoverflow.com/questions/57734032/installing-numpy-scipy-in-python-2-7-now-fails-with-runtimeerror-python-vers
Basically because python2 is deprecated.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3932?email_source=notifications&email_token=ACUKYX4E7BOLP2NAVH5USMDRDZ66FA5CNFSM4KWD3PCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMN25TA#issuecomment-589016780>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUKYXYOZND4DUJZQPHBBB3RDZ66FANCNFSM4KWD3PCA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on VoxForge, I found that the path for sequitur executable is not
$SEQUITUR/bin, It is$SEQUITUR.