Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaldi submodules #4945

Open
judyfong opened this issue Sep 20, 2024 · 4 comments
Open

Kaldi submodules #4945

judyfong opened this issue Sep 20, 2024 · 4 comments

Comments

@judyfong
Copy link

Iunno if this is well known but i have github.com/judyfong/sid
and github.com/cadia-lvl/kaldi-speaker-diarization they are submodules of kaldi for the ruv-di dataset

@judyfong
Copy link
Author

I am interested in merging their history into this repo. However, that would mean altering the history of the repo since it does not follow the kaldi coding guidelines. should I change the history or just make a new repo?

@danpovey
Copy link
Contributor

I wouldn't worry too much about the coding guidelines if it's new recipes-- it won't affect anything existing.

@judyfong
Copy link
Author

judyfong commented Sep 25, 2024 via email

@danpovey
Copy link
Contributor

Sure, what do you want to ask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants