Skip to content

Commit

Permalink
leds: netxbig: set led_classdev max_brightness
Browse files Browse the repository at this point in the history
This patch sets the led_classdev max_brightness to the maximum level
value supported by hardware. This allows to get rid of the brightness
conversion operation (from software [0:LED_FULL] to hardware ranges) in
brightness_set().

Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
  • Loading branch information
simonguinot authored and janaszewski committed Nov 3, 2015
1 parent cd01095 commit 7b9d9d8
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/leds/leds-netxbig.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ struct netxbig_led_data {
int mode_addr;
int *mode_val;
int bright_addr;
int bright_max;
struct netxbig_led_timer *timer;
int num_timer;
enum netxbig_led_mode mode;
Expand Down Expand Up @@ -178,7 +177,7 @@ static void netxbig_led_set(struct led_classdev *led_cdev,
struct netxbig_led_data *led_dat =
container_of(led_cdev, struct netxbig_led_data, cdev);
enum netxbig_led_mode mode;
int mode_val, bright_val;
int mode_val;
int set_brightness = 1;
unsigned long flags;

Expand All @@ -204,12 +203,9 @@ static void netxbig_led_set(struct led_classdev *led_cdev,
* SATA LEDs. So, change the brightness setting for a single
* SATA LED will affect all the others.
*/
if (set_brightness) {
bright_val = DIV_ROUND_UP(value * led_dat->bright_max,
LED_FULL);
if (set_brightness)
gpio_ext_set_value(led_dat->gpio_ext,
led_dat->bright_addr, bright_val);
}
led_dat->bright_addr, value);

spin_unlock_irqrestore(&led_dat->lock, flags);
}
Expand Down Expand Up @@ -306,11 +302,11 @@ static int create_netxbig_led(struct platform_device *pdev,
*/
led_dat->sata = 0;
led_dat->cdev.brightness = LED_OFF;
led_dat->cdev.max_brightness = template->bright_max;
led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;
led_dat->mode_addr = template->mode_addr;
led_dat->mode_val = template->mode_val;
led_dat->bright_addr = template->bright_addr;
led_dat->bright_max = template->bright_max;
led_dat->timer = pdata->timer;
led_dat->num_timer = pdata->num_timer;
/*
Expand Down

0 comments on commit 7b9d9d8

Please sign in to comment.