Skip to content

Commit

Permalink
reset: Mark function as static and remove unused function in core.c
Browse files Browse the repository at this point in the history
Mark function of_reset_simple_xlate() as static in core.c
because it is not used outside this file.
Also, remove functions devm_reset_control_put() and
devm_reset_control_match() because they are unused.

This eliminates the following warnings in core.c:
drivers/reset/core.c:46:5: warning: no previous prototype for ‘of_reset_simple_xlate’ [-Wmissing-prototypes]
drivers/reset/core.c:262:6: warning: no previous prototype for ‘devm_reset_control_put’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
  • Loading branch information
rashika authored and pH5 committed Feb 3, 2014
1 parent 3d10302 commit 0c5b2b9
Showing 1 changed file with 1 addition and 29 deletions.
30 changes: 1 addition & 29 deletions drivers/reset/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ struct reset_control {
* This simple translation function should be used for reset controllers
* with 1:1 mapping, where reset lines can be indexed by number without gaps.
*/
int of_reset_simple_xlate(struct reset_controller_dev *rcdev,
static int of_reset_simple_xlate(struct reset_controller_dev *rcdev,
const struct of_phandle_args *reset_spec)
{
if (WARN_ON(reset_spec->args_count != rcdev->of_reset_n_cells))
Expand All @@ -54,7 +54,6 @@ int of_reset_simple_xlate(struct reset_controller_dev *rcdev,

return reset_spec->args[0];
}
EXPORT_SYMBOL_GPL(of_reset_simple_xlate);

/**
* reset_controller_register - register a reset controller device
Expand Down Expand Up @@ -243,33 +242,6 @@ struct reset_control *devm_reset_control_get(struct device *dev, const char *id)
}
EXPORT_SYMBOL_GPL(devm_reset_control_get);

static int devm_reset_control_match(struct device *dev, void *res, void *data)
{
struct reset_control **rstc = res;
if (WARN_ON(!rstc || !*rstc))
return 0;
return *rstc == data;
}

/**
* devm_reset_control_put - resource managed reset_control_put()
* @rstc: reset controller to free
*
* Deallocate a reset control allocated withd devm_reset_control_get().
* This function will not need to be called normally, as devres will take
* care of freeing the resource.
*/
void devm_reset_control_put(struct reset_control *rstc)
{
int ret;

ret = devres_release(rstc->dev, devm_reset_control_release,
devm_reset_control_match, rstc);
if (ret)
WARN_ON(ret);
}
EXPORT_SYMBOL_GPL(devm_reset_control_put);

/**
* device_reset - find reset controller associated with the device
* and perform reset
Expand Down

0 comments on commit 0c5b2b9

Please sign in to comment.